Don't touch files if they don't need changing #133
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for looking into this as fast as you did 🚀 Modified mtime of flake.nix via running afterwards my old install of nixfmt results in: which demonstrates the difference again :) so LGTM |
infinisil
requested changes
Sep 26, 2023
infinisil
approved these changes
Oct 2, 2023
infinisil
reviewed
Oct 2, 2023
Lucus16
approved these changes
Oct 4, 2023
|
I'd merge, but can't because CI doesn't seem to run |
piegamesde
force-pushed
the
piegames/fix-mtime
branch
from
4bd2689 to
2cab4bd
Compare
|
CI doesn't seem to be running, I have no idea what's happening there. I could probably manually merge and push to master, but that would be undesirable. The CI is broken in #132 too btw |
|
We'll need to get #134 merged for CI to work. If you don't want to wait for it, just run CI locally and then merge to master manually. |
piegamesde
force-pushed
the
piegames/fix-mtime
branch
from
2cab4bd to
ca9c897
Compare
0x4A6F
added a commit
to 0x4A6F/nixpkgs
that referenced
this pull request
Mar 8, 2024
dasJ
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 11, 2024
nixfmt-rfc-style: apply NixOS/nixfmt#133
jian-lin
pushed a commit
to linj-fork/nixpkgs
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
This has not been tested yet, CC @SebTM please take a look